[PATCH] D121756: [clang-format] Clean up code looking for if statements

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added a comment.

In D121756#3398165 <https://reviews.llvm.org/D121756#3398165>, @sstwcw wrote:

> It turned out this patch does change behavior.
>
>   -  while (
>   -      FormatTok->isOneOf(tok::identifier, tok::kw_requires, tok::coloncolon)) {
>   +  while (FormatTok->isOneOf(tok::identifier, tok::kw_requires,
>   +                            tok::coloncolon)) {
>
> So what do I do?
>
> And what's the regression suite?

I like to run clang-format over all the files in LLVM that were previously clang-formatted, (now be careful because some people don't keep their files formatted), but you can run this over the ~8000 files in LLVM that are clang-format clean, this should give you a good idea of if you change is breaking stuff.

clang-format -verbose -n -files ./clang/docs/tools/clang-formatted-files.txt


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121756/new/

https://reviews.llvm.org/D121756