[PATCH] D122143: [clang][dataflow] Add support for disabling warnings on smart pointers.

Mon Mar 21 11:15:18 PDT 2022

ymandel marked 2 inline comments as done.
ymandel added a comment.

In D122143#3396729 <https://reviews.llvm.org/D122143#3396729>, @xazax.hun wrote:

> In D122143#3396695 <https://reviews.llvm.org/D122143#3396695>, @ymandel wrote:
>
>> So, do you mean to add a FIXME to move to allowlist, or do you mean to hold off until we've switched? I have a short-term interest in getting this through for a particular usecase, but I understand if you feel it just not a good idea. Regardless, I'm going to get started exploring an allowlist approach.
>
> I see the precedent of FIXMEs getting followed up in this effort, so I'm fine with a FIXME for now :)

Thanks for the confidence. FIXME added.

================
Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:301
+        cxxOperatorCallExpr(anyOf(hasOverloadedOperatorName("->"),
+                                  hasOverloadedOperatorName("*")),
+                            unless(hasArgument(0, expr(hasOptionalType())))))));
----------------
xazax.hun wrote:
> It is probably rarely used, but one could use `std::unique_ptr` with an array of `std::optional`s and use `operator[]` to access the optional.
I added a note to the option itself and also changed its name to be more specific.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122143/new/

https://reviews.llvm.org/D122143