[PATCH] D122104: [X86][regcall] Support passing / returning structures

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:744
+  void setMaxVectorWidth(unsigned Width) {
+    MaxVectorWidth = llvm::Log2_32(Width) + 1;
+  }
----------------
Are you assuming Width is a power of 2? Should we assert that?


================
Comment at: clang/lib/CodeGen/CGCall.cpp:4673
 
+unsigned getMaxVectorWidth(const llvm::Type *Ty) {
+  if (auto *VT = dyn_cast<llvm::VectorType>(Ty))
----------------
`static`?


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:3740
   QualType Ty, unsigned freeIntRegs, unsigned &neededInt, unsigned &neededSSE,
-  bool isNamedArg)
+  bool isNamedArg, bool IsRegCall)
   const
----------------
clang-format


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122104/new/

https://reviews.llvm.org/D122104