[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

Mon Mar 21 08:12:39 PDT 2022

fhahn added a comment.

In D117829#3389241 <https://reviews.llvm.org/D117829#3389241>, @RKSimon wrote:

> In D117829#3386398 <https://reviews.llvm.org/D117829#3386398>, @fhahn wrote:
>
>> @RKSimon are you planning on pushing this patch through? From my perspective, it looks good with splitting off `__builtin_reduce_mul` and adding a TODO to also implement it for floating point types.
>
> You mean handle add/mul in separate patches? I'm happy to continue with this, I just didn't want to make it more difficult for us to add fp support in the future - particularly if we do end up needing the scalar initial_value argument

Yeah that's what I meant. I'm not sure about the need for supporting a scalar initial value, but implementing a subset of the specified behavior for now shouldn't cause much trouble further down the line hopefully.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117829/new/

https://reviews.llvm.org/D117829