[PATCH] D122089: [CUDA] Add getTargetFeatures for the NVPTX toolchain

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 21 07:46:31 PDT 2022


jdoerfert added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:635
+                                   const llvm::opt::ArgList &Args,
+                                   std::vector<StringRef> &Features,
+                                   Optional<clang::CudaVersion> CudaVersion) {
----------------
Why std::vector. looks like this only returns 1 anyway, no?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122089/new/

https://reviews.llvm.org/D122089



More information about the cfe-commits mailing list