[PATCH] D119655: [Driver][NetBSD] -r: imply -nostdlib like GCC

[Mikael Holmén via Phabricator via cfe-commits]

uabelho added inline comments.
Herald added a project: All.


================
Comment at: clang/test/Driver/netbsd.c:477
+// RELOCATABLE-NOT: "-l
+// RELOCATABLE-NOT: crt{{[^.]+}}.o
----------------
Hi,

I see this CHECK-NOT fail every now and then due to bad luck:

13:48:46 /repo/bbiswjenk/fem2s10-eiffel176/workspace/llvm/llvm-main-gcc/clang/test/Driver/netbsd.c:477:21: error: RELOCATABLE-NOT: excluded string found in input
13:48:46 // RELOCATABLE-NOT: crt{{[^.]+}}.o
13:48:46                     ^
13:48:46 <stdin>:6:286: note: found here
13:48:46  "/proj/bbi_twh/wh_bbi/x86_64-Linux2/bbigcc/1.9.3.0/crosscompiler/bin/ld" "--sysroot=/repo/bbiswjenk/fem2s10-eiffel176/workspace/llvm/llvm-main-gcc/clang/test/Driver/Inputs/basic_netbsd_tree" "--eh-frame-hdr" "-dynamic-linker" "/libexec/ld.elf_so" "-o" "a.out" "-r" "-r" "/tmp/lit-tmp-crtcq7cs/netbsd-94b421.o"
13:48:46                                                                                                                                                                                                                                                                                              ^~~~~~~~~~~~~~~~~~~~~~~~

Same thing with

13:59:16 Failed Tests (5):
13:59:16   Clang :: Driver/freebsd.c
13:59:16   Clang :: Driver/fuchsia.c
13:59:16   Clang :: Driver/linux-cross.cpp
13:59:16   Clang :: Driver/netbsd.c
13:59:16   Clang :: Driver/openbsd.c

Perhaps the CHECK-NOT can be made stricter to avoid these matches due to bad luck?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119655/new/

https://reviews.llvm.org/D119655