[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

Konrad Wilhelm Kleine via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 21 03:11:09 PDT 2022


kwk added a comment.

In D121370#3387175 <https://reviews.llvm.org/D121370#3387175>, @HazardyKnusperkeks wrote:

> In D121370#3383574 <https://reviews.llvm.org/D121370#3383574>, @HazardyKnusperkeks wrote:
>
>> Some test with a main header and blocks would be nice.
>
> This one please. :)

Done.



================
Comment at: clang/lib/Format/Format.cpp:2762
+        // This addresses https://github.com/llvm/llvm-project/issues/38995
+        int WithSemicolon = false;
+        if (!IncludeName.startswith("\"") && !IncludeName.startswith("<") &&
----------------
MyDeveloperDay wrote:
> int false?
> int false?

Yes, this was just to see if everybody is awake ;). Just kiddin'. Good catch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121370/new/

https://reviews.llvm.org/D121370



More information about the cfe-commits mailing list