[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

Sat Mar 19 01:02:53 PDT 2022

cor3ntin marked 2 inline comments as done.
cor3ntin added inline comments.

================
Comment at: clang/test/CXX/dcl.dcl/dcl.spec/dcl.constexpr/dtor.cpp:1
-// RUN: %clang_cc1 -std=c++2a -verify %s

----------------
hubert.reinterpretcast wrote:
> aaron.ballman wrote:
> > I think we want to keep testing the C++20 behavior and want new tests for the C++2b behavior. We still need to be sure we're correct in C++20 mode given the differences (even in extensions because `-pedantic-errors` is a thing). So I'd recommend splitting this test into two or using an additional RUN line.
> @cor3ntin, I don't think Aaron's comment has been addressed. I think keeping `-std=c++2a` and adding `-Wc++2b-extensions` would be appropriate. I know there are tests elsewhere that also focus on paragraph 3, but this test has coverage specifically for destructors.
Yes, I missed that, thanks

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111400/new/

https://reviews.llvm.org/D111400