[PATCH] D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C.

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

LGTM, thanks for the clarification!



================
Comment at: clang/test/Sema/attr-cpuspecific.c:133
 
-// FIXME: Declaration of a non-overloadable function when more than one
-// FIXME: multiversion function declarations are present results in an
-// FIXME: assertion failure.
 int __attribute__((cpu_dispatch(generic))) bad_overload3(void);
 int __attribute__((cpu_specific(ivybridge))) bad_overload3(void);
----------------
tahonermann wrote:
> erichkeane wrote:
> > In what way is this test different than bad_overload1?
> `bad_overload1` has `cpu_specific` in both declarations while the declarations for `bad_overload3` exercise both `cpu_dispatch` and `cpu_specific`. 
Ah!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121959/new/

https://reviews.llvm.org/D121959