[PATCH] D121958: [clang] NFC: Remove forced type merging in multiversion function checks.

[Tom Honermann via Phabricator via cfe-commits]

tahonermann added a comment.

> Hmm... my understanding is "MergeTypeWithPrevious" is important for cases where we decide that this is a redeclaration, right? We need to set it to 'false' when we "know" that this is a different declaration, right? So at least the '=false' was correct?

As best as I can tell, `MergeTypeWithPrevious` is only `true` when 1) compiling as C, 2) the previous declaration (if any) is not shadowed, and 3) there is no visible previous declaration and there is a conflicting non-visible declaration. When already set to `true`, setting it to `false` would likely defeat some later diagnostics.

I spent a while trying to intuit a test that demonstrated different behavior before and after this change and wasn't able to identify one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121958/new/

https://reviews.llvm.org/D121958