[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith added inline comments.


================
Comment at: clang/test/Driver/compilation_database_multiarch.c:5-6
+
+// CHECK:      { "directory": "{{.*}}", "file": "{{.*}}", "output": "{{.*}}", "arguments": [{{.*}} "--target=x86_64-apple-macosx12.0.0"]},
+// CHECK-NEXT: { "directory": "{{.*}}", "file": "{{.*}}", "output": "{{.*}}", "arguments": [{{.*}} "--target=arm64-apple-ios5.0.0"]},
----------------
dexonsmith wrote:
> I guess this is off topic, but this is the wrong output. Would be good to fix this — maybe first to avoid adding a test for the wrong behaviour. Running on macOS 12, I would expect:
> ```
> % clang -arch x86_64 -arch arm64 /dev/null -x c -###
> ```
> to emit
> ```
> ".../path/to/clang" "-cc1" "-triple" "x86_64-apple-macosx12.0.0" ...
> ".../path/to/clang" "-cc1" "-triple" "arm64-apple-macosx12.0.0" ...
> ```
> and that's what I get from the clang that comes with Xcode. But I reproduced the incorrect output you're checking for here with the clang at llvm.org.
> 
> Is there something we forgot to upstream? @arphaman, do you know?
Heh, typo in my reproducer above, which I fixed when I ran it to check but forgot to copy back into Phabricator. Correctly-spelled `-###` command is:
```
% clang -arch x86_64 -arch arm64 -x c /dev/null -c -###
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121997/new/

https://reviews.llvm.org/D121997