[PATCH] D121733: Clean pathnames in FileManager.

Paul Pluzhnikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 18 11:23:49 PDT 2022


ppluzhnikov added a comment.

> There's also some others where I wouldn't expect them to be failing in this patch, eg. the ones from `/` -> `{{[/\\]}}`.

These are failing because `remove_dots` (un-intuitively) also changes "foo/bar\\baz" to "foo\\bar\\baz"

> Are there tests that we can't just fix to expect either `/` or `\\`?

That's what this change is doing (but there is more Winx64 cleanup pending; sorry, I should have sent this as a draft, but I am still learning the ropes here).

> Why do we need to change the underlying behaviour here at all?

Sorry, I didn't understand that comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121733/new/

https://reviews.llvm.org/D121733



More information about the cfe-commits mailing list