[PATCH] D121733: Clean pathnames in FileManager.

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith added reviewers: dexonsmith, benlangmuir, bnbarham, arphaman, vsapsai.
dexonsmith added a comment.

I haven't had time yet to think through the implications of this.

At first glance this seems fine/correct/great. The only case I know of where `./` means something is if you're running an executable, some shells block finding executables in the current path without it. I don't think the FileManager is used for cleaning up relative paths to executables (in the unlikely case such a usecase grows, the caller can surely handle this!).

However, FileManager changes sometimes have odd side effects... and it's possible that somewhere in clang relies on having `FileManager::getFileRef()` return precisely the same path that was requested. Tagging a few other people that have some context... please share your opinions!

@ppluzhnikov, can you give more context on how this interacts with https://reviews.llvm.org/D121658? I had a quick look but it wasn't immediately obvious.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121733/new/

https://reviews.llvm.org/D121733