[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

[Kim Gräsman via Phabricator via cfe-commits]

kimgr added inline comments.


================
Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:362-364
+  { A k = to_lvalue_ref(A().ret_a()); } // expected-error {{'alloc::A::ret_a' is not a constant expression}} expected-error {{'alloc::to_lvalue_ref' is not a constant expression}}
+  // expected-note at -1 {{temporary created here}}
+  // expected-note at -2 {{heap-allocated object is not a constant expression}} expected-note at -2 {{reference to temporary is not a constant expression}}
----------------
aaron.ballman wrote:
> I usually prefer line continuation characters because I think it makes the test easier to read (it's easy to miss secondary diagnostics on the same line). However, I don't insist on these changes either (but if you make them, please do similar for the other test lines you're touching).
Thanks, I wasn't aware there was support for line continuation. I agree it would benefit readability here, so I'll look into it. 


================
Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:365
-  { int k = A().ret_a().ret_i(); }
-  { int k = by_value_a(A()); }
   { int k = const_a_ref(A()); }
----------------
aaron.ballman wrote:
> Why are we dropping this test coverage?
Good question, that must've been a mistake. I'll take another look. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119477/new/

https://reviews.llvm.org/D119477