[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 18 06:27:56 PDT 2022


erichkeane added a comment.

In D121961#3391988 <https://reviews.llvm.org/D121961#3391988>, @aaron.ballman wrote:

> Is there a need for this functionality? The text node dumper already dumps attributes associated with the function: https://godbolt.org/z/EbW8E74TT
>
> If the change is necessary, it needs some test coverage (I'd recommend adding the test to the `clang/test/AST` directory).

I would have found this helpful while working with MV functions in the past, particularly 'target' ones.  So there is perhaps some value and minimal harm to this.  That said, we definitely need a test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121961/new/

https://reviews.llvm.org/D121961



More information about the cfe-commits mailing list