[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In D117522#3390136 <https://reviews.llvm.org/D117522#3390136>, @LegalizeAdulthood wrote:

> I think I've got all the changes incorporated, but I'm getting a test failure so I haven't uploaded a new diff.
>
> Honestly, I don't understand the test failure output.  On Windows, the test failure output is all mangled and
> difficult to interpret correctly as to what exactly is the problem, so I'm still trying to figure it out.

If you're able to post the output you're getting, I can try to help psychically debug it.

> Improving the readability of the test failures is one of the things I would like to address in a future change.
> I suspect it's only a problem on Windows as it seems most of the clang-tidy devs are using unix?

FWIW, I use Windows almost exclusively. Also, clang-tidy is frequently integrated into people's CI pipelines so even folks on *nix can be impacted by the behavior on Windows in those cases. That said, I have no idea what the test failures look like or how likely they are to be hit, so it may be reasonable to improve in a follow-up.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117522/new/

https://reviews.llvm.org/D117522