[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

Daniel Grumberg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 17 17:25:11 PDT 2022


dang added a comment.

In D121936#3391001 <https://reviews.llvm.org/D121936#3391001>, @zixuw wrote:

> In D121936#3390920 <https://reviews.llvm.org/D121936#3390920>, @dang wrote:
>
>> In D121936#3389991 <https://reviews.llvm.org/D121936#3389991>, @ributzka wrote:
>>
>>> Nice! Thank you for adding support for multiple headers. Is this a step towards the json input file list?
>>
>> My understanding was that for this iteration at least we were going with just feeding the headers directly to clang without an input file list. Maybe we should talk about this offline as I might be missing something.
>
> In my initial proposed design, clang-extract-api takes in multiple headers directly as inputs. What would be the need to have a json file list?

It might be better if we need to pass in information about specific headers. We can discuss more offline but I don't think it is necessary for this iteration at least.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121936/new/

https://reviews.llvm.org/D121936



More information about the cfe-commits mailing list