[PATCH] D121907: [clang-format] Use an enum for context types.

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 17 12:46:12 PDT 2022


MyDeveloperDay added a comment.

So out of interest, what is the reason? my assumption is that you wanted to add more for Verilog and you felt adding the extra bools was the wrong design and its better an an enum

  bool InCpp11AttributeSpecifier = false;
  bool InCSharpAttributeSpecifier = false;

Does the fact that some aren't exclusive make you think its ok to split it into enums and bools is ok?  (no real opinion just wondered what you and others think?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121907/new/

https://reviews.llvm.org/D121907



More information about the cfe-commits mailing list