[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

Thu Mar 17 05:15:02 PDT 2022

fhahn added a comment.

In D118259#3343554 <https://reviews.llvm.org/D118259#3343554>, @john.brawn wrote:

> In D118259#3275297 <https://reviews.llvm.org/D118259#3275297>, @fhahn wrote:
>
>> Does this clang test actually need to check the generated assembly? Shouldn't it be enough to check that the correct intrinsics are generated?
>
> I could remove the CHECK-ASM checks, but the other xyz-constrained.c tests (including non-aarch64 ones) all do this and it feels a bit weird to just do that to this test.

I guess the question is if there is a convincing reason to check the assembly in this test? Unless it is required for the test, checking for assembly makes the test more fragile than they need to be. Also, is there any difference in the generated IR between X86 and AArch64? If not, the tests should probably be unified.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118259/new/

https://reviews.llvm.org/D118259