[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

[Renato Golin via Phabricator via cfe-commits]

rengolin added inline comments.


================
Comment at: clang/test/Driver/csky-arch-error.c:1
+// RUN: %clang -target csky-unknown-elf -march=csky -### %s \
+// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=CSKY %s
----------------
This will error out and fail the test. You need to add a `not` before `%clang`.

Check tests in `clang/test/Driver/` that has `not %clang` as their RUN lines and do the same.

And keep all the `not %clang` tests separate from the `%clang` tests.


================
Comment at: clang/test/Driver/csky-arch.c:28
+
+// CHECK-NOT: error: invalid arch name '
+// CSKY-TARGET: "-triple" "csky-unknown-unknown-elf"
----------------
If the RUN line fails (ex. on invalid arch name), the return value will be non-zero and the test will fail, so CHECKing for the absence of errors is no-op.


================
Comment at: clang/test/Driver/csky-cpus.c:12
+// RUN: %clang -target csky -### -c %s 2>&1 -mcpu=generic1 | FileCheck -check-prefix=FAIL-MCPU-NAME %s
+// FAIL-MCPU-NAME: error: the clang compiler does not support '-mcpu=generic1'
+
----------------
Same here, separate `not` tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121445/new/

https://reviews.llvm.org/D121445