[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

Wed Mar 16 17:29:13 PDT 2022

thakis added a comment.

In D121233#3384567 <https://reviews.llvm.org/D121233#3384567>, @sammccall wrote:

> In D121233#3384495 <https://reviews.llvm.org/D121233#3384495>, @thakis wrote:
>
>> Is there a reason why this can't be part of clang-tools-extra/test
>
> This was discussed pretty extensively in the review above.
> Other projects across LLVM use proj/{lib,include,unittest,test} and it works well.
> clang-tools-extra isn't a project but rather a set of separate projects (few common developers, few changes across them). Mixing the directories of different projects doesn't work well.
>
> I want to make it possible to convert more/all of the directories to separate-project structure, so I'm working on reducing the amount of CMake/lit.cfg boilerplate needed.

It seems less work and less toil to make this one new thing look like all the other clang-tools-extra projects than to change all other clang-tools-extra projects to look like this new thing.

> Thanks. I'd seen that but thought clang-tools-extra didn't have this requirement/wasn't being tested in this way. I'm a bit reluctant to add these without a way to tell if it's doing anything, is there a buildbot to verify this or a script to run?

Open the generated lit.site.cfg and verify that paths in there are relative. Check that check-foo still passes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121233/new/

https://reviews.llvm.org/D121233