[PATCH] D121757: [clang-format] Take out common code for parsing blocks

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 16 13:57:34 PDT 2022


HazardyKnusperkeks added a comment.

Looks basically okay.



================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2851
-    addUnwrappedLine();
-    ++Line->Level;
-    parseStructuralElement();
----------------
This is completely missing. Didn't it affect anything?


================
Comment at: clang/lib/Format/UnwrappedLineParser.h:128
   void parseTryCatch();
+  void parseIndentedBlock(bool BracesAreOptional = true,
+                          bool RBraceOnSeparateLine = true);
----------------
I'm no fan of default arguments.
But we have them all around...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121757/new/

https://reviews.llvm.org/D121757



More information about the cfe-commits mailing list