[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

zhouyizhou via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 16 06:49:47 PDT 2022


zhouyizhou added a comment.

In D121498#3385896 <https://reviews.llvm.org/D121498#3385896>, @erichkeane wrote:

> LGTM!  Let me know if you need me to commit this for you (and if so, what name/email address you'd like it committed under).

Thank you for your guidance!
I do need you to commit this for me. I want my name and following email address be committed with the patch:
Zhouyi Zhou<zhouzhouyi at gmail.com>

Thanks again
Zhouyi



================
Comment at: clang/lib/AST/Type.cpp:3330
 
+  case EST_Uninstantiated:
+    return CT_Dependent;
----------------
erichkeane wrote:
> Slight preference for moving just this line to 3351 (above or below) to get the fallthrough behavior on the existing CT_Dependent without condition.
thank you for your guidance, thanks zhouyi


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121498/new/

https://reviews.llvm.org/D121498



More information about the cfe-commits mailing list