[PATCH] D121588: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

[Iain Sandoe via Phabricator via cfe-commits]

iains marked 3 inline comments as done.
iains added inline comments.


================
Comment at: clang/lib/Frontend/FrontendOptions.cpp:30-31
       .Case("cppm", Language::CXX)
+      .Case("iih", InputKind(Language::CXX).getPreprocessed())
       .Case("iim", InputKind(Language::CXX).getPreprocessed())
       .Case("cl", Language::OpenCL)
----------------
iains wrote:
> vsapsai wrote:
> > Given the other branches in this StringSwitch I would expect `.Cases("iih", "iim", InputKind(Language::CXX).getPreprocessed())`. Is there a reason not to do that (like differences between iih and iim) or is it accidental?
> accidental on someone's part, I expect .. but pre-existing
> (I have not [intentionally, at least] modified the behaviour of non-header unit module in this patch set)
hmm.. sorry I misread .. I will update this to use Cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121588/new/

https://reviews.llvm.org/D121588