[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

Is there a reason why this can't be part of clang-tools-extra/test and check-clang-tools?

Why is this in a directory called "pseudo" instead of "clang-pseudo"? This makes everything fairly self-inconsistent (`pseudo/tool` vs `clang-pseudo` in there, but then also `check-clang-pseudo`) – I found this pretty confusing.

Reading `CMAKE_CURRENT_SOURCE_DIR` in the lit.cfg is fairly unusual. clang's unit tests don't do this, for example.

New lit.cfg input files should use the `path()` abstraction so that relative paths are in the generated lit.cfg output files (which helps for running the tests on a different computer than building them). See a16ba6fea2e554fae465dcaaca1d687d8e83a62e <https://reviews.llvm.org/rGa16ba6fea2e554fae465dcaaca1d687d8e83a62e> for an example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121233/new/

https://reviews.llvm.org/D121233