[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 15 16:45:02 PDT 2022


hubert.reinterpretcast added inline comments.


================
Comment at: clang/test/CodeGen/PowerPC/atomic-alignment.c:1
+// REQUIRES: powerpc-registered-target
+// RUN: %clang_cc1 -verify -triple powerpc-unkonwn-unknown -emit-llvm -o - %s | \
----------------
I am not sure about having a `CodeGen` test for this when a `-fsyntax-only` `Layout` test would do. I believe that also removes the need for `powerpc-registered-target`.


================
Comment at: clang/test/Sema/atomic-ops.c:7-8
 // RUN:   -fsyntax-only -triple=powerpc64-linux-gnu -std=c11
+// RUN: %clang_cc1 %s -verify -fgnuc-version=4.2.1 -ffreestanding \
+// RUN:   -fsyntax-only -triple=powerpc64le-linux-gnu -std=c11
 
----------------
Consider testing across the `-mcpu=power7` and `-mcpu=power8` boundary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121441/new/

https://reviews.llvm.org/D121441



More information about the cfe-commits mailing list