[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

[Julian Lettner via Phabricator via cfe-commits]

yln added a comment.

Hi @Orlando and @RKSimon!

Thanks for pointing out the test failure and reverting the change.  I see this failure:

  : 'RUN: at line 1';   /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/opt        -lower-global-dtors -S < /home/buildbot/buildbot-root/llvm-project/llvm/test/Transforms/LowerGlobalDestructors/lower-global-dtors.ll | /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/FileCheck /home/buildbot/buildbot-root/llvm-project/llvm/test/Transforms/LowerGlobalDestructors/lower-global-dtors.ll --implicit-check-not=llvm.global_dtors
  : 'RUN: at line 2';   /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/opt -passes=lower-global-dtors -S < /home/buildbot/buildbot-root/llvm-project/llvm/test/Transforms/LowerGlobalDestructors/lower-global-dtors.ll | /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/FileCheck /home/buildbot/buildbot-root/llvm-project/llvm/test/Transforms/LowerGlobalDestructors/lower-global-dtors.ll --implicit-check-not=llvm.global_dtors
  --
  Exit Code: 2
  Command Output (stderr):
  --
  opt: Unknown command line argument '-lower-global-dtors'.  Try: '/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/opt --help'
  opt: Did you mean '--join-globalcopies'?

This looks like my changes are not sufficiently registering the pass for `opt` on every platform, but so far I haven't found anything that is obviously wrong/missing.  Do you know who I can reach out to help me with "pass registration"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121327/new/

https://reviews.llvm.org/D121327