[PATCH] D121646: [Concepts] Fix an assertion failure while diagnosing constrained function candidates

Tue Mar 15 12:52:15 PDT 2022

royjacobson added a comment.

In D121646#3382243 <https://reviews.llvm.org/D121646#3382243>, @erichkeane wrote:

> In D121646#3380902 <https://reviews.llvm.org/D121646#3380902>, @royjacobson wrote:
>
>> In D121646#3380893 <https://reviews.llvm.org/D121646#3380893>, @erichkeane wrote:
>>
>>> This seems acceptable to me. Though, I wonder if `getTemplateArgumentBindingsText` should produce the leading space, that way we could just pass the result of it directly, rather than have to create a SmallString everywhere.  WDYT?
>>
>> There are other places (outside SemaOverload) that use this function and don't need a space, though.
>> I thought about just putting the space in the diagnostic itself, but then sometimes you don't get template arguments and it fails.
>
> I see.  I was hoping that wasn't the case!  OK, LGTM.  Let me know if you need me to commit this for you.

Yes, thank you :)
(with author as "Roy Jacobson <roi.jacobson1 at gmail.com>")

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121646/new/

https://reviews.llvm.org/D121646