[PATCH] D121497: Lex: add support for `{,u}i128` Microsoft extension

Tue Mar 15 11:18:16 PDT 2022

aaron.ballman added a comment.

> The Windows SDK has occurrences of the i128 and ui128 suffix (at least in the 10.0.22000.0 SDK, see intsafe.h). This adds support for the extension to properly lex the literal.

Something fishy is still going on here. I definitely see the use in intsafe.h, but it seems that `i128` is not supported by MSVC nor is `__int128` as a type: https://godbolt.org/z/K36baejq6 in neither C nor C++ mode, at least not for any architecture I can find. Were you running into compile errors with clang-cl when compiling intsafe.h, or was this more speculative that since it's in the header it must be supported? I have the distinct impression this is a bug in the Windows SDK: https://godbolt.org/z/sTx8W4a51.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121497/new/

https://reviews.llvm.org/D121497