[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 15 09:37:06 PDT 2022


aaron.ballman accepted this revision.
aaron.ballman added a comment.

In D121245#3382887 <https://reviews.llvm.org/D121245#3382887>, @ArcsinX wrote:

> In D121245#3380346 <https://reviews.llvm.org/D121245#3380346>, @aaron.ballman wrote:
>
>> LGTM! Might be worth adding a release note for it (does this close any bugs in the bug database? If so, it'd be worth mentioning those in the commit message and release note).
>
> Thank you for review.
>
> I failed to find any opened bugs related to this. I'm not sure how detailed information about this patch should be in release notes. Can you please take a look at `ReleaseNotes.rst` modifications?

The release notes look great to me, thank you for adding them!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121245/new/

https://reviews.llvm.org/D121245



More information about the cfe-commits mailing list