[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

Mon Mar 14 19:31:12 PDT 2022

owenpan added a comment.

In D121576#3378934 <https://reviews.llvm.org/D121576#3378934>, @MyDeveloperDay wrote:

> I'm wondering if the presence of the comment would impact the CellCount, I might go back and add some more unit tests for the "non rectangular" change I made.
>
> So this fixes the "}" going up onto the comment line, but not the indentation right?

Right. I think we should have a specification (including when not to align the cells) and re-design the entire thing. It's not maintainable as is. I have some ideas but need to remove/change some of the existing test cases, e.g., those involving concatenated string literals. If you (and @curdeius and @HazardyKnusperkeks) agree, I can give it a shot.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121576/new/

https://reviews.llvm.org/D121576