[PATCH] D121646: [Concepts] Fix an assertion failure while diagnosing constrained function candidates

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

This seems acceptable to me. Though, I wonder if `getTemplateArgumentBindingsText` should produce the leading space, that way we could just pass the result of it directly, rather than have to create a SmallString everywhere.  WDYT?



================
Comment at: clang/lib/Sema/SemaOverload.cpp:10261
+          SmallString<128> TemplateArgString;
+          TemplateArgString.clear();
+          if (FunctionTemplateDecl *FunTmpl = FD->getPrimaryTemplate()) {
----------------
.clear shouldn't be required as you just constructed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121646/new/

https://reviews.llvm.org/D121646