[PATCH] D121368: [pseudo][WIP] Build Ambiguous forest node in the GLR Parser.

Alex Tsao via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 14 11:18:07 PDT 2022


alextsao1999 added inline comments.


================
Comment at: clang/lib/Tooling/Syntax/Pseudo/GLRParser.cpp:318
         Bases.push_back(
-            {Base, ParsingTable.getGoToState(Base->State, ReduceRule.Target)});
+            {Base, ParsingTable.getGoToState(Base->State, ReduceSymbolID)});
       llvm::sort(Bases, [](const BaseInfo &L, const BaseInfo &R) {
----------------
Maybe we can make goto more clear? like `performGoto` after every GLR reduction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121368/new/

https://reviews.llvm.org/D121368



More information about the cfe-commits mailing list