[PATCH] D121295: [clang][deps] Modules don't contribute to search path usage

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 14 10:45:15 PDT 2022


dexonsmith added inline comments.


================
Comment at: clang/lib/Lex/HeaderSearch.cpp:305
   // maps, searching for a module map that describes this module.
-  for (It = search_dir_begin(); It != search_dir_end(); ++It) {
-    if (It->isFramework()) {
+  for (DirectoryLookup Dir : search_dir_range()) {
+    if (Dir.isFramework()) {
----------------
This triggers a bunch of noise in this patch. Is it possible to make this change either before or after, to avoid the noise, giving that there's a functional change hiding here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121295/new/

https://reviews.llvm.org/D121295



More information about the cfe-commits mailing list