[PATCH] D120527: [OpaquePtr][AArch64] Use elementtype on ldxr/stxr

Arthur Eubanks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 14 10:08:32 PDT 2022


aeubanks added a comment.

In D120527#3372092 <https://reviews.llvm.org/D120527#3372092>, @dmgreen wrote:

> Seems OK. Thanks for the patch.
>
> Do opaque pointer variants (like `i32 @llvm.aarch64.stxr.p0(i64 1, ptr elementtype(i64) %ptr.0)`) get tested automatically from the existing tests once -opaque-pointers is the default?

yup

In D120527#3371927 <https://reviews.llvm.org/D120527#3371927>, @nikic wrote:

> LGTM. You probably want to add these intrinsics to the auto-upgrade code in `BitcodeReader::propagateAttributeTypes()` as well.

done


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120527/new/

https://reviews.llvm.org/D120527



More information about the cfe-commits mailing list