[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

Sun Mar 13 14:28:21 PDT 2022

HazardyKnusperkeks accepted this revision.
HazardyKnusperkeks added a comment.

In D112019#3378031 <https://reviews.llvm.org/D112019#3378031>, @MyDeveloperDay wrote:

> In D112019#3378024 <https://reviews.llvm.org/D112019#3378024>, @HazardyKnusperkeks wrote:
>
>> Why limit to macros, could it be a member of AlignConsecutiveStyle and apply to the other stuff as well?
>
> I personally don't have a use case other than the resource.h case that I raise above, do you think this would be useful to be elsewhere in the other AlignConsecutive cases?
>
> Of course, this code alters AlignMacroSequence() and not AlignTokens() what if we unified the options (so they were part of the struct? but kept the functionality change in separate reviews? for now the options would have no effect on other Consecutive options?

I don't know if there will be a use case. The more I think about it, it maybe harder to apply it to the other options.
I withdraw my comment. :)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112019/new/

https://reviews.llvm.org/D112019