[PATCH] D121549: Define ABI breaking class members correctly

Daniil Kovalev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 13 05:01:34 PDT 2022


kovdan01 created this revision.
kovdan01 added reviewers: dexonsmith, craig.topper.
Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, ThomasRaoux, msifontes, ecnelises, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, mravishankar, rriddle, mehdi_amini, javed.absar, hiraditya, qcolombet, MatzeB.
Herald added a reviewer: antiagainst.
Herald added a project: All.
kovdan01 requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, stephenneuendorffer, nicolasvasilache.
Herald added projects: clang, MLIR, LLVM.

Non-static class members declared under #ifndef NDEBUG should be declared
under #if LLVM_ENABLE_ABI_BREAKING_CHECKS to make headers library-friendly and
allow cross-linking.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D121549

Files:
  clang/lib/Sema/TypeLocBuilder.cpp
  clang/lib/Sema/TypeLocBuilder.h
  llvm/include/llvm/CodeGen/GlobalISel/GISelWorkList.h
  llvm/include/llvm/CodeGen/MachineScheduler.h
  llvm/include/llvm/CodeGen/PBQP/ReductionRules.h
  llvm/include/llvm/CodeGen/RegAllocPBQP.h
  llvm/include/llvm/CodeGen/SelectionDAG.h
  llvm/lib/CodeGen/MachineScheduler.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp
  llvm/lib/Target/SystemZ/SystemZHazardRecognizer.h
  mlir/lib/Target/SPIRV/Deserialization/Deserializer.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121549.414927.patch
Type: text/x-patch
Size: 12735 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220313/7529ddae/attachment-0001.bin>


More information about the cfe-commits mailing list