[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 11 17:38:49 PST 2022


vsapsai added a comment.

In D121176#3372193 <https://reviews.llvm.org/D121176#3372193>, @martong wrote:

> Basically, this looks good to me. But my confidence with ObjC is low, so, I'd like @shafik as well to approve.
> Besides, seems like the pre-merge check fails with the new tests on Debian, could you please address that?

Thanks for the review! My confidence with the structural equivalence is low and I appreciate your expertise in this area.

Fixed the tests by using non-fragile ABI explicitly. The only remaining failing test is `Clang :: Driver/clang_f_opts.c` which is failing for unrelated reasons.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121176/new/

https://reviews.llvm.org/D121176



More information about the cfe-commits mailing list