[PATCH] D121426: [VFS] Update uses of getVFSFromYAML to use the new getVFSFromYAMLs API

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 11 17:17:23 PST 2022


dexonsmith added a comment.

> Includes two test fixes (since chained mappings are no longer allowed)
> and adds a new test for multiple overlays.

Are we sure no one needs to support chained mappings? Has there been a ~~clang-dev~~ discourse discussion about it already? Just concerned that some vendor might rely on being able to support this.



================
Comment at: llvm/include/llvm/Support/Error.h:1284
 
-  StringRef getFileName() { return FileName; }
+  StringRef getFileName() const { return FileName; }
 
----------------
bnbarham wrote:
> Should this be in a change all by itself?
Yes, but I also know you already split this out so I guess you just need to rebase :).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121426/new/

https://reviews.llvm.org/D121426



More information about the cfe-commits mailing list