[PATCH] D120610: [DebugInfo] Include DW_TAG_skeleton_unit when looking for parent UnitDie
Wenlei He via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 11 13:29:15 PST 2022
wenlei added a comment.
In D120610#3376002 <https://reviews.llvm.org/D120610#3376002>, @dblaikie wrote:
> It'd be good to include some testing beyond "does not crash" - like what was the specific debug info we were trying to create when the crash was hit? Perhaps we should be testing that (since the crash demonstrates we weren't testing that anywhere else)
Sure, added a few checks around `DW_TAG_template_type_parameter` for both `DW_TAG_skeleton_unit` and `DW_TAG_skeleton_unit`. Let me know whether what I have here aligns with the convention of similar tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120610/new/
https://reviews.llvm.org/D120610
More information about the cfe-commits
mailing list