[PATCH] D121455: [clang][dataflow] Add support for nested composite bool expressions
Gábor Horváth via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 11 09:21:11 PST 2022
xazax.hun added inline comments.
================
Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:516
+ // assigned to it.
+ Visit(&SubExpr);
+ if (auto *Val = dyn_cast_or_null<BoolValue>(
----------------
Could you elaborate on when would this happen? I'd expect the traversal to always visit the predecessor basic blocks first and within a basic block always visit subexpressions first. So I'd be quite surprised if there is a subexpression we did not visit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121455/new/
https://reviews.llvm.org/D121455
More information about the cfe-commits
mailing list