[PATCH] D121466: [OpenMP] Replace math headers with OpenMP wrapper calls

[Jon Chesterfield via Phabricator via cfe-commits]

JonChesterfield added a comment.

We've got quite a lot of debt in this area and seem at risk of taking on more. Ideally the cuda and hip and openmp headers would be closer to a single header containing:

double acosh(double);
INSTANTIATE(acosh, cuda_acosh, amdgpu_acosh, intel_acosh);



================
Comment at: clang/lib/Headers/openmp_wrappers/__clang_openmp_math.h:43
+
+__DEVICE__ int abs(int __a) { return __omp_abs(__a); }
+__DEVICE__ double fabs(double __a) { return __omp_fabs(__a); }
----------------
This is not totally good. Can we do something with macros or code generators instead, even in the first instance?

Also wonder if what we actually want to do is map these things onto `__gpu_acosh` or `__llvm_gpu_acosh` or similar, there's nothing openmp specific about this and it would be really nice to not end up spinning another copy of this for some other gpu language.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121466/new/

https://reviews.llvm.org/D121466