[PATCH] D121378: [clang][dataflow] Model the behavior of various optional members

Thu Mar 10 09:00:02 PST 2022

sgatev marked an inline comment as done.
sgatev added inline comments.

================
Comment at: clang/unittests/Analysis/FlowSensitive/UncheckedOptionalAccessModelTest.cpp:33
 static constexpr char StdTypeTraitsHeader[] = R"(
+#ifndef TYPE_TRAITS_H
+#define TYPE_TRAITS_H
----------------
xazax.hun wrote:
> I wonder if it is more sustainable in the long term to have these headers in a separate file and `#include` them here (and build the raw string literal with a macro if that is possible at all).
Yeap, I agree that would be better. I'll consider some options and send a patch to move them out of here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121378/new/

https://reviews.llvm.org/D121378