[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

James Y Knight via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 10 07:34:13 PST 2022


jyknight added a comment.

In D118511#3371432 <https://reviews.llvm.org/D118511#3371432>, @tstellar wrote:

> I'm fine with reverting if you think this is the best solution.  I just would like to conclude soon so I can make the final release candidate.

ISTM that reverting the ABI change in the 14.x branch makes sense, to avoid ping-ponging the ABI for packed structs which would become non-packed (breaking ABI) in 14.x and packed again (breaking ABI) in https://reviews.llvm.org/D119051.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118511/new/

https://reviews.llvm.org/D118511



More information about the cfe-commits mailing list