[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

Thanks Aaron, and my apologies for being easily frustrated.

In D121233#3370992 <https://reviews.llvm.org/D121233#3370992>, @aaron.ballman wrote:

> 2. The layout of clang-tools-extra in terms of test directories is problematic and it'd sure be nice if someday someone moved the test directories under the individual tools instead of using a top-level test directory.

I'd really like to enable this.
I think the blocker is mostly the amount of boilerplate needed to set up test directories. 
These required files are mostly boilerplate:

- test/CMakeLists.txt (deps are meaningful, rest is boilerplate)
- test/lit.site.cfg.py.in
- test/lit.cfg.py
- test/Unit/lit.site.cfg.py.in (this patch puts these under unittest/ instead, but either way)
- test/Unit/lit.cfg.py

Creating 10 more copies of each of those seems a little irresponsible, especially for tools that are "lightly maintained". So it's hard to say with a straight face that restructuring them all is a good idea, and maybe this motivated the original clang-tools-extra structure.
But if those files were generated/eliminated somehow, restructuring would be very simple patches that didn't add more cruft to maintain.

It's not obvious to me exactly how to do this (lit.* files affect both discovery and configuration) but I'll dig into this more tomorrow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121233/new/

https://reviews.llvm.org/D121233