[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

[Manoj Gupta via Phabricator via cfe-commits]

manojgupta added a comment.

For the background, we had hit this in Chrome OS when building bluetooth code.

This is the one of structs hitting the issue where the warning got promoted to an error:

typedef struct {
<snip>
private:

  static std::string AppendCapability(std::string& result, bool append,
                                      const std::string& name) {
   <snip>
  }

} btav_a2dp_codec_config_t;

Previously this was a warning that was suppressed in this code upstream using -Wno-non-c-typedef-for-linkage  but now it turns into a non-suppressible error.

The exact code actually comes from aosp, but this is the Chrome OS public accessible copy:
https://chromium.googlesource.com/aosp/platform/packages/modules/Bluetooth/+/main/system/include/hardware/bt_av.h


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121328/new/

https://reviews.llvm.org/D121328