[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

[David Blaikie via Phabricator via cfe-commits]

dblaikie added a comment.

In D118511#3369114 <https://reviews.llvm.org/D118511#3369114>, @tbaeder wrote:

> Hey @dblaikie, seems like this has never been pushed?

Yeah, was holding off on this because it looked like maybe there was still outstanding work on the nuance/precise nature of the ABI change - turned out to be a known/outstanding issue: https://reviews.llvm.org/D119051 though it does have some impact on the warning and the layout change: If we get that POD ABI fix in, then the layout change/warning will fire on fewer places. So it seems sort of unfortunate to add the warning & end up having folks cleaning up things that don't need cleaning up once the POD ABI change happens.

But equally, bad to ship the layout change without teh associated warning.

Thoughts? Revert the layout change for now/in the release until the broader POD ABI issue is addressed? Then apply the layout change+warning?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118511/new/

https://reviews.llvm.org/D118511