[PATCH] D121294: [AArch64][SVE][Clang] Fix crash for incorrect svptrue and svcnt parameters

[Sander de Smalen via Phabricator via cfe-commits]

sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

In D121294#3370132 <https://reviews.llvm.org/D121294#3370132>, @MattDevereau wrote:

> In D121294#3370085 <https://reviews.llvm.org/D121294#3370085>, @sdesmalen wrote:
>
>> This is missing tests for svundef, svrdffr, svsetffr and svpfalse?
>
> @sdesmalen Only svcnt and svptrue cause the crash. This might be because of extra values added by the `[IsAppendSVALL]` TypeFlag in `arm_sve.td`. We decided to change other intrinsics with 0 parameters as there seems to be no drawbacks to doing so and it might catch further future errors.

Fair enough. Since you're adding the `void` to the prototype for a reason (the diagnostic behaviour now changes), I figured you may as well want to test it.



================
Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/negative/acle_sve_svptrue.c:2
+// REQUIRES: aarch64-registered-target
+
+// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -fsyntax-only -verify %s
----------------
MattDevereau wrote:
> sdesmalen wrote:
> > Is it possible to use the `update_cc_test_checks.py` script for these tests?
> Deleting `// expected-error-re at +1...` and running `update_cc_test_checks.py` did not generate anything in its place in either of the tests
Okay I wasn't sure, so thanks for confirming.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121294/new/

https://reviews.llvm.org/D121294