[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

Wed Mar 9 09:03:33 PST 2022

steven_wu added a comment.

In D118352#3368922 <https://reviews.llvm.org/D118352#3368922>, @ChuanqiXu wrote:

> In D118352#3368919 <https://reviews.llvm.org/D118352#3368919>, @phosek wrote:
>
>> We're also seeing this issue on our Mac bots, is it possible to revert it?
>
> I've reverted it. Since this is the new feature, I think it wouldn't so hurry to land it. BTW, I think it would be helpful to provide more information to fix it.

It breaks the macOS bot for LLVM, you can click the test case for its output: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/27745/testReport/

You can see the error output. The problem might be that `dso_local` does not get codegen for macho targets.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118352/new/

https://reviews.llvm.org/D118352