[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

Jennifer Yu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 9 08:17:22 PST 2022


jyu2 added inline comments.


================
Comment at: clang/lib/Sema/SemaStmtAsm.cpp:679
+          !llvm::isPowerOf2_32(OutSize))
+        targetDiag(OutputExpr->getExprLoc(), diag::err_store_value_to_reg);
+
----------------
Error message is not very clear to me.  I think we should create more specified error message there.  Like power of two, or size <  8 or > pointer size?

Using error message selector.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107141/new/

https://reviews.llvm.org/D107141



More information about the cfe-commits mailing list